Build 981 - Keying through filtered variable suggestions doesn't account for filter

Continua CI Bugs
1

Hi

I'll try and explain as best I can:

  1. In a stage's Workspace Repository Rules, start typing a variable. As an example a source var, where the repo's first letter is P:  $Source.P

  2. The suggestion box below the edit box filters to show own those variables that start with $Source.P

  3. Pressing the keyboard arrow keys to select a suggestion appears to cycle through an unfiltered version of the selection list. As a result you can wind up entering $Source.NotRelevant$ instead of, in this case, one of the filtered suggestions that starts with P.


Cheers


Joel

2

I just pushed a fix for this, will be in next build.

3

Thanks Vinnie - I’m not sure if this is related, but now if you hit the ‘enter’ key while selecting from this list, the entire dialog is closed as opposed to just the list of suggestions. I’m pretty sure that previously ‘enter’ would only select the currently highlighted selection?

This has caught me out a few times selecting branches while manually queuing a build.

4

Hi Joel, I’ll take a look at this today.

There’s two slightly different types of auto-complete in Continua, one with AJAX support and one without. The ajax one is used pretty much everywhere except for the queue build dialog. The bug you first reported was fixed only in the ajax auto complete. It also appears to be in the non-ajax one on the queue build dialog as well so I fixed that this morning and should be in the next build.


The problem with the dialog closing though… does that happen only on the queue build dialog’s auto-complete or does it happen on all of them(Workspace rules, etc… as well)? Do you remember which page you were on when the dialog closed? I’m thinking the queue build dialog may have different outcomes if you’re using it from the Configurations view page or the Projects view page.

5

Looks like Firefox isn’t playing nice with autocomplete

6

That’s something I didn’t think about - I was using Firefox when the ‘Enter’ problem occurred, where previously I was using Chrome. Apologies for not mentioning that

7

It’s all good… switching browsers is usually the first thing we do when we see weird behavior. There was some weirdness between browsers and the order in which they process key event functions. I’ve fixed it though so it’ll be in the next build.